| Summary: | [Blackberry] m_isRequestedByPlugin should be copied in ResourceRequest | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris.Guan <logingx> | ||||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | rwlbuis, tonikitoo, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris.Guan
2012-04-08 20:03:28 PDT
Created attachment 136172 [details]
Patch
Created attachment 136173 [details]
Patch
Comment on attachment 136173 [details] Patch Clearing flags on attachment: 136173 Committed r113569: <http://trac.webkit.org/changeset/113569> All reviewed patches have been landed. Closing bug. Keep in mind that this is a layering violation, so future WebCore refactorings can break your m_isRequestedByPlugin in unexpected ways. ResourceRequest is a network level abstraction, and it should not know anything about web concepts such as plug-ins. Comment on attachment 136173 [details]
Patch
I do not think this flag should even exist :( it was introduced to "fix" a bug in Flash, that it was starting a load in a new window when swapping/scrolling. It did not even fix the problem :/
Also this patch has parts in PluginView (iirc) that are not upstreamed, so they should get upstreamed all together.
Please file a follow up bug to clean it up , as per mine and ap's comments. I already added this in my task queue after AP had comments. I am following up. Actually we had a discussion internally related to this bug, I will add you in. |