Summary: | Command-line jsc's exception handling should be rationalized | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Filip Pizlo
2012-04-08 13:10:01 PDT
Created attachment 136156 [details]
the patch
Comment on attachment 136156 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=136156&action=review > Source/JavaScriptCore/jsc.cpp:532 > if (dump) { > - if (evaluationException) > - printf("Exception: %s\n", evaluationException.toString(globalObject->globalExec())->value(globalObject->globalExec()).utf8().data()); > - else > + if (!evaluationException) Now that there’s no else clause inside you can just write if (dump && !evaluationException) (In reply to comment #2) > (From update of attachment 136156 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136156&action=review > > > Source/JavaScriptCore/jsc.cpp:532 > > if (dump) { > > - if (evaluationException) > > - printf("Exception: %s\n", evaluationException.toString(globalObject->globalExec())->value(globalObject->globalExec()).utf8().data()); > > - else > > + if (!evaluationException) > > Now that there’s no else clause inside you can just write > if (dump && !evaluationException) Good point, thanks for the review! Landed in http://trac.webkit.org/changeset/113553 |