Bug 83436

Summary: [WIN] Use GetDateFormat and GetTimeFormat instead of strftime
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, aroben, bfulgham, jberlin, jhoneycutt, sfalken, yosin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Windows 7   
Attachments:
Description Flags
Patch
aroben: review-
Patch bfulgham: review+

Patrick R. Gansterer
Reported 2012-04-08 12:17:13 PDT
[WIN] Use GetDateFormat and GetTimeFormat instead of strftime
Attachments
Patch (4.77 KB, patch)
2012-04-08 12:23 PDT, Patrick R. Gansterer 		aroben: review-
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2012-05-30 14:18 PDT, Patrick R. Gansterer 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-04-08 12:23:13 PDT
Created attachment 136154 [details] Patch
Adam Roben (:aroben)
Comment 2 2012-04-12 12:22:50 PDT
Comment on attachment 136154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136154&action=review > Source/JavaScriptCore/runtime/DatePrototype.cpp:233 > + UChar buffer[128]; How do we know this is long enough? Maybe we should use something like Vector<UChar, 128> and grow it if it turns out to be too small.
Patrick R. Gansterer
Comment 3 2012-05-30 14:18:47 PDT
Created attachment 144922 [details] Patch
Brent Fulgham
Comment 4 2012-06-11 17:29:25 PDT
Comment on attachment 144922 [details] Patch Looks good to me!
Patrick R. Gansterer
Comment 5 2012-07-21 14:23:00 PDT
Committed r123293: <http://trac.webkit.org/changeset/123293>
yosin
Comment 6 2012-07-22 20:51:07 PDT
FYI: GetTimeFormat works only for year 1601 to 320827. http://msdn.microsoft.com/en-us/library/windows/desktop/ms724950(v=vs.85).aspx It doesn't cover full JavaScript Date range. https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Date/ GetTimeFormat also doesn't work with HTML5 Date range. So, we implemented formatDate for Windows in WebCore. http://trac.webkit.org/browser/trunk/Source/WebCore/platform/text/LocaleWin.cpp
Patrick R. Gansterer
Comment 7 2012-07-23 00:54:31 PDT
(In reply to comment #6) > GetTimeFormat works only for year 1601 to 320827. > http://msdn.microsoft.com/en-us/library/windows/desktop/ms724950(v=vs.85).aspx Yes, but the current call to strftime() does not even return correct values for dates before 1900 on my windows 7 machine with VS2010.
Note You need to log in before you can comment on or make changes to this bug.