Summary: | Don't expose internal CSSValues in API | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, kling, macpherson, menard, rniwa, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 77745, 83540 | ||||||||||||
Attachments: |
|
Description
Antti Koivisto
2012-04-07 11:27:06 PDT
Created attachment 136135 [details]
patch
Created attachment 136136 [details]
rebased
Comment on attachment 136136 [details] rebased Attachment 136136 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12362468 Comment on attachment 136136 [details] rebased Attachment 136136 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12364444 Comment on attachment 136136 [details] rebased Attachment 136136 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12358494 Created attachment 136137 [details]
try to fix build
Comment on attachment 136137 [details] try to fix build Attachment 136137 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12367042 Comment on attachment 136137 [details] try to fix build View in context: https://bugs.webkit.org/attachment.cgi?id=136137&action=review Very cool. r=me. (Though you'll need to do something about the win failure.) > Source/WebCore/css/CSSImageSetValue.cpp:146 > + // Non-CSSValueList data is not accesible through CSS OM, no need to clone. Typo accessible. > Source/WebCore/css/CSSValue.h:38 > +// Please don't expose more CSSValue types to the web. Hear hear. Perhaps we could even get rid of WebKitCSSTransformValue.idl and WebKitCSSFilterValue.idl. > Source/WebCore/css/RGBColor.cpp:42 > + // Unique instances are safe. Don't think this comment is needed. Created attachment 136140 [details]
try to fix win build
Comment on attachment 136140 [details] try to fix win build Rejecting attachment 136140 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12372107 Comment on attachment 136140 [details] try to fix win build Clearing flags on attachment: 136140 Committed r113588: <http://trac.webkit.org/changeset/113588> All reviewed patches have been landed. Closing bug. It seems like this patch regressed some perf. tests: http://webkit-perf.appspot.com/graph.html#tests=[[314224,2001,32196]]&sel=1333978732699.9312,1334010760286.138,1137.9310344827586,1896.5517241379312&displayrange=7&datatype=running |