Bug 83409

Summary: bindAttribLocation should check webgl reserved prefix
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kbr: review+

Zhenyao Mo
Reported 2012-04-06 16:24:53 PDT
right now it just passes down to command buffer, where command buffer only checks for "gl_".
Attachments
Patch (5.72 KB, patch)
2012-04-06 17:19 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
Patch (5.74 KB, patch)
2012-04-09 12:32 PDT, Zhenyao Mo 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2012-04-06 17:19:45 PDT
Created attachment 136106 [details] Patch
Zhenyao Mo
Comment 2 2012-04-06 17:21:11 PDT
Ken, please review.
Kenneth Russell
Comment 3 2012-04-09 11:41:25 PDT
Comment on attachment 136106 [details] Patch Looks good. Can you make sure these changes make it into the WebGL conformance suite (and email public_webgl about their addition)? Thanks.
Zhenyao Mo
Comment 4 2012-04-09 12:32:47 PDT
Created attachment 136285 [details] Patch
Zhenyao Mo
Comment 5 2012-04-09 12:37:43 PDT
The changes are already in the khronos and then I synced to layout tests. I'll email it to the public_webgl.
Zhenyao Mo
Comment 6 2012-04-09 12:45:21 PDT
by the way, the second patch is the same as the first one. I simply did an webkit-update and reuploaded. You don't have to look again.
Kenneth Russell
Comment 7 2012-04-09 15:08:57 PDT
Comment on attachment 136285 [details] Patch Still looks fine.
Zhenyao Mo
Comment 8 2012-04-09 15:40:46 PDT
Committed r113634: <http://trac.webkit.org/changeset/113634>
Note You need to log in before you can comment on or make changes to this bug.