| Summary: | [chromium] Clear values in combinedClear path not respected in WebGLRenderingContext::clearIfComposited() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cc-bugs, kbr, zmo | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
James Robinson
2012-04-06 15:50:39 PDT
Created attachment 136081 [details]
Patch
This fixes the regressions in http://code.google.com/p/chromium/issues/detail?id=122463. I need to add some layout test coverage before landing (which is why I left the OOPS! in), but posting the code first so folks can look at it. Created attachment 136083 [details]
Patch
Turns out fast/canvas/webgl/canvas-test.html covers this when run interactively, but since it was running in DRT without any explicit display() calls we didn't hit the same clearIfComposited() calls and the bug didn't manifest. Tweaked the test to do something closer to what a real browser does so it would catch this regression. Comment on attachment 136083 [details]
Patch
LGTM as long as it's been tested.
Thanks. I've checked this on the layout tests, the failure gpu_tests test, and manually made sure the webgl aquarium shows up so I think we're good. Of course, I thought that last time too so my record isn't that great :) Committed r113517: <http://trac.webkit.org/changeset/113517> |