Bug 83388

Summary: WebFullScreenManagerProxy::isFullScreen() will create an empty full screen window; steal focus.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Jer Noble
Reported 2012-04-06 13:45:35 PDT
WebFullScreenManagerProxy::isFullScreen() will create an empty full screen window; steal focus.
Attachments
Patch (3.10 KB, patch)
2012-04-06 13:50 PDT, Jer Noble 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-04-06 13:46:05 PDT
<rdar://problem/11191249>
Jer Noble
Comment 2 2012-04-06 13:50:31 PDT
Created attachment 136061 [details] Patch
Geoffrey Garen
Comment 3 2012-04-06 14:28:02 PDT
Comment on attachment 136061 [details] Patch r=me It's a little squirrelly for object allocation (in this case) or deallocation (in the general case) to change program behavior. Long-term, it would be nice to separate allocating the full screen window controller from giving it focus.
Jer Noble
Comment 4 2012-04-06 14:35:51 PDT
(In reply to comment #3) > (From update of attachment 136061 [details]) > r=me > > It's a little squirrelly for object allocation (in this case) or deallocation (in the general case) to change program behavior. Long-term, it would be nice to separate allocating the full screen window controller from giving it focus. That stems from using a NSWindowController, which expects to have created a NSWindow as part of its own init process. But you're right, and this is something we should try to mitigate.
Jer Noble
Comment 5 2012-04-06 14:49:31 PDT
Committed r113501: <http://trac.webkit.org/changeset/113501>
Note You need to log in before you can comment on or make changes to this bug.