Bug 83388

Summary: WebFullScreenManagerProxy::isFullScreen() will create an empty full screen window; steal focus.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Description Jer Noble 2012-04-06 13:45:35 PDT
WebFullScreenManagerProxy::isFullScreen() will create an empty full screen window; steal focus.
Comment 1 Jer Noble 2012-04-06 13:46:05 PDT
<rdar://problem/11191249>
Comment 2 Jer Noble 2012-04-06 13:50:31 PDT
Created attachment 136061 [details]
Patch
Comment 3 Geoffrey Garen 2012-04-06 14:28:02 PDT
Comment on attachment 136061 [details]
Patch

r=me

It's a little squirrelly for object allocation (in this case) or deallocation (in the general case) to change program behavior. Long-term, it would be nice to separate allocating the full screen window controller from giving it focus.
Comment 4 Jer Noble 2012-04-06 14:35:51 PDT
(In reply to comment #3)
> (From update of attachment 136061 [details])
> r=me
> 
> It's a little squirrelly for object allocation (in this case) or deallocation (in the general case) to change program behavior. Long-term, it would be nice to separate allocating the full screen window controller from giving it focus.

That stems from using a NSWindowController, which expects to have created a NSWindow as part of its own init process.  But you're right, and this is something we should try to mitigate.
Comment 5 Jer Noble 2012-04-06 14:49:31 PDT
Committed r113501: <http://trac.webkit.org/changeset/113501>