Bug 83383

Summary: [chromium] Add more layout tests a videos that changes dimensions while decoding
Product: WebKit Reporter: Andrew Scherkus <scherkus>
Component: MediaAssignee: Andrew Scherkus <scherkus>
Status: RESOLVED FIXED    
Severity: Normal CC: fischman, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jamesr: review+, jamesr: commit-queue-

Andrew Scherkus
Reported 2012-04-06 12:02:15 PDT
Need tests for both the software rendering path _and_ the compositing path!
Attachments
Patch (4.55 KB, patch)
2012-04-06 12:03 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
Patch (9.01 KB, patch)
2012-04-06 18:01 PDT, Andrew Scherkus 		jamesr: review+
jamesr: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrew Scherkus
Comment 1 2012-04-06 12:03:13 PDT
Created attachment 136047 [details] Patch
James Robinson
Comment 2 2012-04-06 14:45:47 PDT
This doesn't seem to update any expectations - is the idea that we just want to run through the presentation paths, but we don't really want to check what happens (just that we don't crash)?
Andrew Scherkus
Comment 3 2012-04-06 14:56:54 PDT
the compositing/ test does a pixel test and verifies that we're doing the right thing (rendering + scaling decoded video that has differing dimensions from frame zero) the media/ test verifies the DOM-level changes but ideally should also have a pixel test associated with it -- let me update that one
Andrew Scherkus
Comment 4 2012-04-06 18:01:51 PDT
Created attachment 136111 [details] Patch
Andrew Scherkus
Comment 5 2012-04-06 18:02:05 PDT
PTAL
James Robinson
Comment 6 2012-04-06 18:05:39 PDT
Comment on attachment 136111 [details] Patch Looks good but where da PNGs at?
Andrew Scherkus
Comment 7 2012-04-06 18:07:36 PDT
I'll fix up test_expectations.txt and grab them off the bots
Andrew Scherkus
Comment 8 2012-04-06 19:17:49 PDT
patch landed as http://trac.webkit.org/changeset/113536 waiting for baselines to be generated
Andrew Scherkus
Comment 9 2012-04-07 20:47:51 PDT
baselines added in baselines added in http://trac.webkit.org/changeset/113550
Note You need to log in before you can comment on or make changes to this bug.