Summary: | Setting mode for track element results in ASSERT | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anna Cavender <annacc> | ||||||
Component: | Media | Assignee: | Anna Cavender <annacc> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric.carlson, feature-media-reviews, vcarbune, webkit-bug-importer, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 43668 | ||||||||
Attachments: |
|
Description
Anna Cavender
2012-04-06 10:10:56 PDT
Created attachment 136711 [details]
Patch
Comment on attachment 136711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136711&action=review > LayoutTests/media/track/track-mode-expected.txt:25 > +EXPECTED (textTrack.activeCues.length == '1'), OBSERVED '0' FAIL This cuechange event occurs because there is a cue within range at the time that the mode changes from DISABLED to HIDDEN and so it becomes activated. However, the cue is not found in the activeCues list because we fire the event before we update the list. I've filed a bug to report this here: https://www.w3.org/Bugs/Public/show_bug.cgi?id=16701 Comment on attachment 136711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136711&action=review > LayoutTests/media/track/track-mode.html:51 > + setTimeout(testHiddenAndShowing, 1100); The 1100ms timer makes this a *very* long test for DRT. Is there any way to use a substantially shorter timeout? Comment on attachment 136711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136711&action=review >> LayoutTests/media/track/track-mode.html:51 >> + setTimeout(testHiddenAndShowing, 1100); > > The 1100ms timer makes this a *very* long test for DRT. Is there any way to use a substantially shorter timeout? Yes. I'll create a .vtt file with faster cues so we can still check that no events are fired during a period of mode=DISABLED. Created attachment 136740 [details]
patch with faster test
Comment on attachment 136740 [details] patch with faster test Clearing flags on attachment: 136740 Committed r114026: <http://trac.webkit.org/changeset/114026> All reviewed patches have been landed. Closing bug. |