Bug 83370

Summary: [chromium] Scratch texture reused before SkBitmap releases ownership
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, danakj, enne, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Dana Jansens
Reported 2012-04-06 07:56:14 PDT
[chromium] Scratch texture reused before SkBitmap releases ownership
Attachments
Patch (3.79 KB, patch)
2012-04-06 07:56 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (3.55 KB, patch)
2012-07-20 13:02 PDT, Stephen White 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.60 KB, patch)
2012-07-20 13:39 PDT, Stephen White 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-04-06 07:56:35 PDT
Created attachment 136023 [details] Patch This is a repro for the scratch texture bug.
Stephen White
Comment 2 2012-07-20 13:02:25 PDT
Created attachment 153576 [details] Patch
Adrienne Walker
Comment 3 2012-07-20 13:29:37 PDT
Comment on attachment 153576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153576&action=review R=me. Wow, GrAutoScratchTexture is way better than manual locking and unlocking. > Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:207 > + GrAutoScratchTexture ast(gr, desc, GrContext::kExact_ScratchTexMatch); > + SkAutoTUnref<GrTexture> dest(ast.detach()); style nit: Argh, abbreviations.
Stephen White
Comment 4 2012-07-20 13:39:41 PDT
Created attachment 153587 [details] Patch for landing
Stephen White
Comment 5 2012-07-20 13:59:49 PDT
Thanks for the review. I've un-abbreviated the variables on landing.
WebKit Review Bot
Comment 6 2012-07-20 14:24:21 PDT
Comment on attachment 153587 [details] Patch for landing Clearing flags on attachment: 153587 Committed r123260: <http://trac.webkit.org/changeset/123260>
WebKit Review Bot
Comment 7 2012-07-20 14:24:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.