Bug 83365

Summary:

Web Inspector: display frame details in popover on frame strip in Timeline panel

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Andrey Kosyakov

Reported 2012-04-06 07:07:41 PDT

Add a popover with frame details on hover upon frame strip in the Timeline panel.

Attachments
Patch (12.46 KB, patch) 2012-04-06 07:16 PDT, Andrey Kosyakov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2012-04-06 07:16:27 PDT

Created attachment 136019 [details] Patch

Pavel Feldman

Comment 2 2012-04-06 07:26:24 PDT

Comment on attachment 136019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136019&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:372 > + frameStrip.__frame = frame; Since you own this element, there is no point to use __ for the naming. > Source/WebCore/inspector/front-end/TimelinePanel.js:758 > + if (anchor.classList.contains("timeline-frame-strip")) { Please use hasStyleClass for consistency.

Andrey Kosyakov

Comment 3 2012-04-06 07:44:46 PDT

Committed r113434: <http://trac.webkit.org/changeset/113434>

Note You need to log in before you can comment on or make changes to this bug.