Summary: | Web Inspector: display frame details in popover on frame strip in Timeline panel | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Andrey Kosyakov
2012-04-06 07:07:41 PDT
Created attachment 136019 [details]
Patch
Comment on attachment 136019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136019&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:372 > + frameStrip.__frame = frame; Since you own this element, there is no point to use __ for the naming. > Source/WebCore/inspector/front-end/TimelinePanel.js:758 > + if (anchor.classList.contains("timeline-frame-strip")) { Please use hasStyleClass for consistency. Committed r113434: <http://trac.webkit.org/changeset/113434> |