Bug 83361

Summary: [BlackBerry] Upstream BlackBerry change to PatternSkia.cpp
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebKit BlackBerryAssignee: Charles Wei <charles.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, staikos, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch tonikitoo: review+

Description Charles Wei 2012-04-06 04:47:51 PDT 
BlackBerry porting uses the same PatternSkia.cpp,  but doesn't want the v8 specific code.
Comment 1 Charles Wei 2012-04-06 04:52:01 PDT 
Created attachment 136003 [details]
Patch
Comment 2 Rob Buis 2012-04-06 05:43:40 PDT 
Comment on attachment 136003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136003&action=review

One mistake found. Also is Filip not working on this? Or did he touch this file already?

> Source/WebCore/platform/graphics/skia/PatternSkia.cpp:52
>      m_pattern = 0;

This seems wrong.
Comment 3 Rob Buis 2012-04-11 08:10:24 PDT 
Comment on attachment 136003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136003&action=review

>> Source/WebCore/platform/graphics/skia/PatternSkia.cpp:52
>>      m_pattern = 0;
> 
> This seems wrong.

To be clear, it seems like we still want to delete m_pattern? I can imagine we do not want V8 code of course.
Comment 4 Rob Buis 2012-04-11 13:06:14 PDT 
Created attachment 136733 [details]
Patch
Comment 5 Rob Buis 2012-04-11 13:25:59 PDT 
Landed in r113903.