Bug 83343

Summary: Fix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Description Emil A Eklund 2012-04-05 18:41:53 PDT 
Fix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject
Comment 1 Emil A Eklund 2012-04-05 18:44:38 PDT 
Created attachment 135963 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-06 11:56:16 PDT 
Comment on attachment 135963 [details]
Patch

Clearing flags on attachment: 135963

Committed r113471: <http://trac.webkit.org/changeset/113471>
Comment 3 WebKit Review Bot 2012-04-06 11:56:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Allan Sandfeld Jensen 2012-06-25 05:16:36 PDT 
Comment on attachment 135963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135963&action=review

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:267
> +    IntPoint roundedPoint = roundedIntPoint(pointInContainer);
>  
>      if (Scrollbar* horizontalScrollbar = view->horizontalScrollbar()) {
> -        if (horizontalScrollbar->shouldParticipateInHitTesting() && horizontalScrollbar->frameRect().contains(pointInContainer)) {
> +        if (horizontalScrollbar->shouldParticipateInHitTesting() && horizontalScrollbar->frameRect().contains(roundedPoint)) {

I am curious, why is this rounding necessary?