Bug 83277

Summary: [EFL] Create baselines for tests related to caret behaviour
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Sudarsana Nagineni (babu) 2012-04-05 07:27:05 PDT
The following test cases are failing because the PlatformKeyboardEvent doesn't receive the correct keyname(event->string) from DRT EventSender.

editing/input/caret-at-the-edge-of-contenteditable.html
editing/input/reveal-caret-of-multiline-contenteditable.html
editing/input/reveal-caret-of-multiline-input.html
Comment 1 Sudarsana Nagineni (babu) 2012-04-17 01:51:18 PDT
> editing/input/caret-at-the-edge-of-contenteditable.html
> editing/input/reveal-caret-of-multiline-contenteditable.html
> editing/input/reveal-caret-of-multiline-input.html

KeyEvent issue is now fixed in r114250. These tests needs png and txt rebaseline to unksip.
Comment 2 Sudarsana Nagineni (babu) 2012-04-17 02:24:19 PDT
Created attachment 137500 [details]
Patch

Adding baselines and unskipping tests related to cursor positioning behavior
Comment 3 Gyuyoung Kim 2012-04-17 02:33:33 PDT
Comment on attachment 137500 [details]
Patch

Looks good to me. Thank you.
Comment 4 Sudarsana Nagineni (babu) 2012-04-17 03:42:27 PDT
Created attachment 137508 [details]
Patch

fix changelog entry
Comment 5 WebKit Review Bot 2012-04-17 08:37:14 PDT
Comment on attachment 137508 [details]
Patch

Rejecting attachment 137508 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
bKit/chromium/ui --revision 132474 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 132474.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 0 files

Full output: http://queues.webkit.org/results/12417674
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-04-17 09:58:32 PDT
Comment on attachment 137508 [details]
Patch

cq+'ing again to see if it was a temporary problem in the commit bot.
Comment 7 WebKit Review Bot 2012-04-17 11:19:40 PDT
Comment on attachment 137508 [details]
Patch

Clearing flags on attachment: 137508

Committed r114399: <http://trac.webkit.org/changeset/114399>
Comment 8 WebKit Review Bot 2012-04-17 11:19:46 PDT
All reviewed patches have been landed.  Closing bug.