Bug 83256 – Limit -apple- and -khtml- to ENABLE(LEGACY_CSS_VENDOR_PREFIXES)

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)

[Adam Barth]

Created attachment 135774 [details]
Patch

[Benjamin Poulain]

Comment on attachment 135774 [details]
Patch

You should also update the JavaScript bindings for consistency (JSCSSStyleDeclarationCustom.cpp && V8CSSStyleDeclarationCustom.cpp.)

[Adam Barth]

Created attachment 136093 [details]
does not compile

[Benjamin Poulain]

Note that cssPropertyID() is also performance sensitive because of animations driven by JavaScript. I think a flag is not a bad idea if the other option is adding branches.

[Adam Barth]

Created attachment 136099 [details]
Patch

[WebKit Review Bot]

Comment on attachment 136099 [details]
Patch

Attachment 136099 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12370125

New failing tests:
inspector/styles/vendor-prefixes.html
fast/css/apple-prefix.html

[WebKit Review Bot]

Created attachment 136204 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[WebKit Review Bot]

Comment on attachment 136099 [details]
Patch

Attachment 136099 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12368167

New failing tests:
inspector/styles/vendor-prefixes.html
fast/css/apple-prefix.html

[WebKit Review Bot]

Created attachment 136210 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Eric Seidel (no email)]

Comment on attachment 136099 [details]
Patch

LGTM, and we haven't heard any further objections.  You'll need to update the test results for chromium.

[Adam Barth]

Created attachment 136407 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 136407 [details]
Patch for landing

Rejecting attachment 136407 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
um/test_expectations.txt
patching file LayoutTests/platform/efl/Skipped
Hunk #1 succeeded at 2637 (offset -18 lines).
patching file LayoutTests/platform/gtk/Skipped
Hunk #1 FAILED at 1640.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej
patching file LayoutTests/platform/qt/Skipped
Hunk #1 succeeded at 2586 (offset 6 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12380446

[Adam Barth]

Created attachment 136529 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 136529 [details]
Patch for landing

Clearing flags on attachment: 136529

Committed r113795: <http://trac.webkit.org/changeset/113795>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 136529 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=136529&action=review

> Source/WebCore/Configurations/FeatureDefines.xcconfig:88
>  ENABLE_JAVASCRIPT_DEBUGGER = ENABLE_JAVASCRIPT_DEBUGGER;
> +ENABLE_LEGACY_CSS_VENDOR_PREFIXES = ENABLE_LEGACY_CSS_VENDOR_PREFIXES;
>  ENABLE_LEGACY_NOTIFICATIONS = ENABLE_LEGACY_NOTIFICATIONS;

As a heads up, the FeatureDefines.xcconfig file across components JavaScriptCore / WebCore / WebKit / WebKit2  should be kept identical. I don't see that written down anywhere though.

[Benjamin Poulain]

> As a heads up, the FeatureDefines.xcconfig file across components JavaScriptCore / WebCore / WebKit / WebKit2  should be kept identical. I don't see that written down anywhere though.

That is kinda documented: http://trac.webkit.org/wiki/AddingFeatures

[Alexey Proskuryakov]

*** Bug 42093 has been marked as a duplicate of this bug. ***