Bug 83244

Summary: [mac] WKTR should always keep its windows offscreen
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, jberlin, jonlee, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 81965    
Attachments:
Description Flags
patch simon.fraser: review+, simon.fraser: commit-queue-

Description Tim Horton 2012-04-04 19:46:57 PDT
Tests that use window.resize jump onto the main display. This is really annoying.

I have a patch.
Comment 1 Radar WebKit Bug Importer 2012-04-04 19:47:10 PDT
<rdar://problem/11188764>
Comment 2 Tim Horton 2012-04-04 19:59:59 PDT
Created attachment 135749 [details]
patch
Comment 3 Simon Fraser (smfr) 2012-04-04 20:16:32 PDT
Comment on attachment 135749 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135749&action=review

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:79
> +    if(_shouldUseFakeOrigin)

Space after if.

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:83
> +    else
> +        return currentFrame;
> +}

No else after a return.
Comment 4 Tim Horton 2012-04-04 21:29:39 PDT
(In reply to comment #3)
> (From update of attachment 135749 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135749&action=review
> 
> > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:79
> > +    if(_shouldUseFakeOrigin)
> 
> Space after if.
> 
> > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:83
> > +    else
> > +        return currentFrame;
> > +}
> 
> No else after a return.

Thanks!

Landed in http://trac.webkit.org/changeset/113288