Summary: | [mac] WKTR should always keep its windows offscreen | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | Tools / Tests | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, jberlin, jonlee, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 81965 | ||||||
Attachments: |
|
Description
Tim Horton
2012-04-04 19:46:57 PDT
Created attachment 135749 [details]
patch
Comment on attachment 135749 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=135749&action=review > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:79 > + if(_shouldUseFakeOrigin) Space after if. > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:83 > + else > + return currentFrame; > +} No else after a return. (In reply to comment #3) > (From update of attachment 135749 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135749&action=review > > > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:79 > > + if(_shouldUseFakeOrigin) > > Space after if. > > > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:83 > > + else > > + return currentFrame; > > +} > > No else after a return. Thanks! Landed in http://trac.webkit.org/changeset/113288 |