Bug 83225 – [CMake] Do not pass -P to the preprocessor when running make_names.pl.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Raphael Kubo da Costa (:rakuco)]

[CMake] Do not pass -P to the preprocessor in the common case.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 135696 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 135696 [details]
Patch

Attachment 135696 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12338025

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 135696 [details]
Patch

Removing flags for now; this needs more thought in order not to break generate-bindings and the regexes in IDLStructure.pm.

[Patrick R. Gansterer]

Why do you want to remove the flag?

[Patrick R. Gansterer]

(In reply to comment #4)
> Why do you want to remove the flag?
Sorry, ChangeLog explains it already. ;-)

[Raphael Kubo da Costa (:rakuco)]

Created attachment 135961 [details]
A hopefully better approach

[Patrick R. Gansterer]

Comment on attachment 135961 [details]
A hopefully better approach

if you really need to split up, i'd like to see that code only on one place (OptionsCommon.cmake) IMHO it would be clearer to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS for all compilers, so we can use it in WebKitMacros.cmake directly.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #7)
> (From update of attachment 135961 [details])
> if you really need to split up, i'd like to see that code only on one place (OptionsCommon.cmake) IMHO it would be clearer to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS for all compilers, so we can use it in WebKitMacros.cmake directly.

At first I thought of making it have the same value as CODE_GENERATOR_PREPROCESSOR for MSVC and QNX. Is that what you mean?

[Patrick R. Gansterer]

(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 135961 [details] [details])
> > if you really need to split up, i'd like to see that code only on one place (OptionsCommon.cmake) IMHO it would be clearer to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS for all compilers, so we can use it in WebKitMacros.cmake directly.
> 
> At first I thought of making it have the same value as CODE_GENERATOR_PREPROCESSOR for MSVC and QNX. Is that what you mean?

yes

[Raphael Kubo da Costa (:rakuco)]

Created attachment 136346 [details]
A better approach, take 2

[Rob Buis]

Comment on attachment 136346 [details]
A better approach, take 2

Looks good.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 136346 [details]
A better approach, take 2

Clearing flags on attachment: 136346

Committed r113786: <http://trac.webkit.org/changeset/113786>

[Raphael Kubo da Costa (:rakuco)]

All reviewed patches have been landed.  Closing bug.