Bug 83224

Summary: [Part 4] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: CSSAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, dglazkov, kling, macpherson, rakuco, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Alexis Menard (darktears)
Reported 2012-04-04 15:05:13 PDT
[Part 4] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
Attachments
Patch (16.78 KB, patch)
2012-04-04 15:06 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.17 KB, patch)
2012-04-04 17:16 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.56 KB, patch)
2012-04-04 17:21 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.17 KB, patch)
2012-04-04 17:33 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2012-04-04 15:06:13 PDT
Created attachment 135693 [details] Patch
Build Bot
Comment 2 2012-04-04 15:44:26 PDT
Comment on attachment 135693 [details] Patch Attachment 135693 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12327199
WebKit Review Bot
Comment 3 2012-04-04 16:44:25 PDT
Comment on attachment 135693 [details] Patch Attachment 135693 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12329140
Benjamin Poulain
Comment 4 2012-04-04 17:16:00 PDT
Created attachment 135726 [details] Patch for landing
Benjamin Poulain
Comment 5 2012-04-04 17:21:22 PDT
Created attachment 135727 [details] Patch for landing
Benjamin Poulain
Comment 6 2012-04-04 17:24:46 PDT
Sorry about that, I do 2 things at the same time and mixed the repositories.
Benjamin Poulain
Comment 7 2012-04-04 17:33:50 PDT
Created attachment 135729 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-04-04 20:08:28 PDT
Comment on attachment 135729 [details] Patch for landing Clearing flags on attachment: 135729 Committed r113281: <http://trac.webkit.org/changeset/113281>
WebKit Review Bot
Comment 9 2012-04-04 20:08:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.