Bug 83177

Summary: [Chromium] TestWebKitAPI links in WebCore twice
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dpranke, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2012-04-04 10:17:36 PDT
[Chromium] TestWebKitAPI links in WebCore twice
Attachments
Patch (1.67 KB, patch)
2012-04-04 10:19 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.21 KB, patch)
2012-04-04 11:08 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-04-04 10:19:13 PDT
Created attachment 135619 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2012-04-04 10:28:08 PDT
Comment on attachment 135619 [details] Patch Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this?
Dimitri Glazkov (Google)
Comment 3 2012-04-04 10:40:00 PDT
Oh, forgot! Can you add it back to build as a target in All.gyp?
Adam Barth
Comment 4 2012-04-04 10:42:32 PDT
> All.gyp? That's in Chromium-land, right? I'll take care of adding it back once the roll happens.
Adam Barth
Comment 5 2012-04-04 10:43:16 PDT
> Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this? Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests.
Dimitri Glazkov (Google)
Comment 6 2012-04-04 10:44:14 PDT
No, that's Source/WebKit/chromium/All.gyp. I removed it here: http://trac.webkit.org/changeset/113201
Adam Barth
Comment 7 2012-04-04 11:08:44 PDT
Created attachment 135631 [details] Patch for landing
Dirk Pranke
Comment 8 2012-04-04 12:07:10 PDT
(In reply to comment #5) > > Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this? > > Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests. Yes ... this is run on the build.webkit.org bots (run-api-tests), but we should probably be running them on the canaries as well.
WebKit Review Bot
Comment 9 2012-04-04 13:28:02 PDT
Comment on attachment 135631 [details] Patch for landing Clearing flags on attachment: 135631 Committed r113231: <http://trac.webkit.org/changeset/113231>
WebKit Review Bot
Comment 10 2012-04-04 13:28:06 PDT
All reviewed patches have been landed. Closing bug.
David Levin
Comment 11 2012-04-04 22:58:07 PDT
(In reply to comment #5) > > Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this? > > Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests. Ideally webkit_unit_tests and this would be combined. I think folding webkit_unit_tests into this would be ideal.
Note You need to log in before you can comment on or make changes to this bug.