Summary: | [Chromium] TestWebKitAPI links in WebCore twice | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, dpranke, levin, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Adam Barth
2012-04-04 10:17:36 PDT
Created attachment 135619 [details]
Patch
Comment on attachment 135619 [details]
Patch
Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this?
Oh, forgot! Can you add it back to build as a target in All.gyp? > All.gyp?
That's in Chromium-land, right? I'll take care of adding it back once the roll happens.
> Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this?
Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests.
No, that's Source/WebKit/chromium/All.gyp. I removed it here: http://trac.webkit.org/changeset/113201 Created attachment 135631 [details]
Patch for landing
(In reply to comment #5) > > Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this? > > Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests. Yes ... this is run on the build.webkit.org bots (run-api-tests), but we should probably be running them on the canaries as well. Comment on attachment 135631 [details] Patch for landing Clearing flags on attachment: 135631 Committed r113231: <http://trac.webkit.org/changeset/113231> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > > Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this? > > Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests. Ideally webkit_unit_tests and this would be combined. I think folding webkit_unit_tests into this would be ideal. |