Bug 83169

Summary:

Update LayoutUnit usage in RenderInputSpeech::paintInputFieldSpeechButton

Product:

WebKit

Reporter:

Levi Weintraub <leviw>

Component:

Layout and Rendering

Assignee:

Levi Weintraub <leviw>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

dglazkov, eae, eric, jchaffraix, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

60318

Attachments:

Description	Flags
Patch	webkit.review.bot: commit-queue-
Patch2	none

Description Levi Weintraub 2012-04-04 09:05:12 PDT

Called from RenderTheme code, and therefor with an IntRect, we need to make sure we handle variables from the render tree properly.

Comment 1 Levi Weintraub 2012-04-04 09:48:36 PDT

Created attachment 135613 [details]
Patch

Not yet requesting a review since this isn't enabled on Apple's Mac port. I want to see this pass the Chromium EWS bot to ensure the refactoring is correct first.

Comment 2 WebKit Review Bot 2012-04-04 10:52:41 PDT

Comment on attachment 135613 [details]
Patch

Attachment 135613 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12320971

Comment 3 Levi Weintraub 2012-04-04 10:59:54 PDT

Created attachment 135628 [details]
Patch2

Now with 100% fewer compiler errors?

Comment 4 Levi Weintraub 2012-04-05 06:33:20 PDT

My patch had some refactoring, but the main issue is resolved.

*** This bug has been marked as a duplicate of bug 83089 ***