Summary: | Implement animatedPathSegList support for SVGPathElement | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | krit, schenney, zherczeg, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 12437 | ||||||
Bug Blocks: | 41761 | ||||||
Attachments: |
|
Description
Nikolas Zimmermann
2012-04-04 03:57:28 PDT
Created attachment 135552 [details]
Patch
Comment on attachment 135552 [details] Patch Well done! r=me with a few comments: View in context: https://bugs.webkit.org/attachment.cgi?id=135552&action=review > Source/WebCore/ChangeLog:8 > + Add last missing piece of animVal support: animations of the SVGPathElement's 'd' attribute Add the last > Source/WebCore/svg/SVGAnimatedType.cpp:441 > + // AnimatedColor is only used for CSS property animations. > + if (type == AnimatedUnknown || type == AnimatedColor) > return false; > - } > - > - ASSERT_NOT_REACHED(); > - return false; > + return true; What about: return (type != AnimatedUnknown && type != AnimatedColor); > Source/WebCore/svg/SVGAnimatedTypeAnimator.h:43 > + virtual PassOwnPtr<SVGAnimatedType> startAnimValAnimation(const Vector<SVGAnimatedProperty*>&) = 0; > + virtual void stopAnimValAnimation(const Vector<SVGAnimatedProperty*>&) = 0; > + virtual void resetAnimValToBaseVal(const Vector<SVGAnimatedProperty*>&, SVGAnimatedType*) = 0; > + virtual void animValWillChange(const Vector<SVGAnimatedProperty*>&) = 0; > + virtual void animValDidChange(const Vector<SVGAnimatedProperty*>&) = 0; Really happy to see them as pure virtual finally! Committed r113184: <http://trac.webkit.org/changeset/113184> |