Bug 83138

Summary: DOM measurement APIs should operate on pixel snapped values.
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch for landing none

Levi Weintraub
Reported 2012-04-04 03:44:59 PDT
These APIs are defined to be integers, so we should use the actual rendered integers when returning values to JS.
Attachments
Patch (5.00 KB, patch)
2012-04-04 04:03 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.02 KB, patch)
2012-04-05 04:43 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-04-04 04:03:41 PDT
Created attachment 135550 [details] Patch
Julien Chaffraix
Comment 2 2012-04-04 14:51:02 PDT
Comment on attachment 135550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135550&action=review > Source/WebCore/dom/Element.cpp:351 > if (RenderBoxModelObject* rend = renderBoxModelObject()) Let's remove those abreviations (not repeated on all the other changes) while at it: renderBoxModelObject would be my favorite but at least renderer would be OK. (note that also most of this logic could use const RenderObject's but that's another - definitely bug-worthy - story)
Levi Weintraub
Comment 3 2012-04-05 04:19:52 PDT
Comment on attachment 135550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135550&action=review >> Source/WebCore/dom/Element.cpp:351 >> if (RenderBoxModelObject* rend = renderBoxModelObject()) > > Let's remove those abreviations (not repeated on all the other changes) while at it: renderBoxModelObject would be my favorite but at least renderer would be OK. > > (note that also most of this logic could use const RenderObject's but that's another - definitely bug-worthy - story) Done and done! Good point and thanks for the review :)
Levi Weintraub
Comment 4 2012-04-05 04:43:17 PDT
Created attachment 135804 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-04-05 05:49:39 PDT
Comment on attachment 135804 [details] Patch for landing Clearing flags on attachment: 135804 Committed r113317: <http://trac.webkit.org/changeset/113317>
WebKit Review Bot
Comment 6 2012-04-05 05:49:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.