Summary: | [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ChangSeok Oh <kevin.cs.oh> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ericu, eric, haraken, kbr, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 58443 | ||||||||
Attachments: |
|
Description
ChangSeok Oh
2012-04-04 03:34:19 PDT
The error message is like that... CONSOLE MESSAGE: line 27: TypeError: 'undefined' is not a function (evaluating 'this[testsList[testCounter++]]()') FAIL: Timed out waiting for notifyDone to be called Created attachment 135768 [details]
Patch
Comment on attachment 135768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review > LayoutTests/fast/filesystem/script-tests/flags-passing.js:27 > + window[testsList[testCounter++]](); The change looks OK, but we can simplify the code more, like this: var testsList = [runObjectTest, cleanupAndRunNext, ...]; // An array of functions (not function names) ... else { (testsList[testCounter++])(); } Created attachment 135781 [details]
Patch
Comment on attachment 135768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review Thanks for the review! >> LayoutTests/fast/filesystem/script-tests/flags-passing.js:27 >> + window[testsList[testCounter++]](); > > The change looks OK, but we can simplify the code more, like this: > > var testsList = [runObjectTest, cleanupAndRunNext, ...]; // An array of functions (not function names) > > ... else { > (testsList[testCounter++])(); > } Done. :) Comment on attachment 135781 [details]
Patch
Looks OK. Thanks for fixing the bug!
Comment on attachment 135781 [details] Patch Clearing flags on attachment: 135781 Committed r113305: <http://trac.webkit.org/changeset/113305> All reviewed patches have been landed. Closing bug. |