Bug 83131

Summary: [BlackBerry] Force compositing mode when backing store is not active
Product: WebKit Reporter: Arvid Nilsson <anilsson>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fspacek, jkjiang, jpetsovits, manyoso, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Arvid Nilsson 2012-04-04 02:09:56 PDT 
Normally, we'd resort to direct rendering when the backing store is not active. However, direct rendering is broken with OpenGL compositing code path, and we have a better option anyway - use accelerated compositing layer to render the root layer instead of backing store. This will give us a tiled layer backing the root layer.

This in turn will enable multiple web pages to be composited at once with the new WebPageCompositor API.
Comment 1 Arvid Nilsson 2012-04-04 02:39:50 PDT 
Created attachment 135536 [details]
Patch
Comment 2 Arvid Nilsson 2012-04-04 02:41:05 PDT 
I think this patch could use an internal reviewer as well as an external, since I think this is not Antonio or Rob's area of expertise. But you're certainly welcome to do it if you feel up to the task =)
Comment 3 Filip Spacek 2012-04-04 13:10:04 PDT 
The patch looks great to me
Comment 4 Arvid Nilsson 2012-04-05 04:18:48 PDT 
Created attachment 135800 [details]
Patch
Comment 5 Arvid Nilsson 2012-04-05 04:19:39 PDT 
(In reply to comment #4)
> Created an attachment (id=135800) [details]
> Patch

ChangeLog entry updated with the fact that it was reviewed internally by Filip Spacek. Ready for external review =)
Comment 6 George Staikos 2012-04-05 05:41:32 PDT 
Comment on attachment 135800 [details]
Patch

Second r+!
Comment 7 Arvid Nilsson 2012-04-05 08:10:05 PDT 
Comment on attachment 135800 [details]
Patch

This can be landed indepently of the webcore patch we're depending on. I'll just remove the dependency.
Comment 8 WebKit Review Bot 2012-04-05 08:57:27 PDT 
Comment on attachment 135800 [details]
Patch

Clearing flags on attachment: 135800

Committed r113325: <http://trac.webkit.org/changeset/113325>
Comment 9 WebKit Review Bot 2012-04-05 08:57:32 PDT 
All reviewed patches have been landed.  Closing bug.