Summary: | Fix usage of LayoutUnits and snapping for scrolling in RenderBox | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, eric, jchaffraix, leviw, simon.fraser, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 60318 | ||||||||||
Attachments: |
|
Description
Emil A Eklund
2012-04-03 14:34:41 PDT
Created attachment 135434 [details]
Patch
Comment on attachment 135434 [details] Patch Attachment 135434 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12315008 New failing tests: fast/dom/Element/scrollWidth.html Created attachment 135453 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 135461 [details]
Patch
Turns out we do not snap the scrollWidth in RTL for a reason, had forgotten about that. Good thing we have great the test coverage for this code. Comment on attachment 135461 [details]
Patch
OK.
Comment on attachment 135461 [details] Patch Clearing flags on attachment: 135461 Committed r113223: <http://trac.webkit.org/changeset/113223> All reviewed patches have been landed. Closing bug. |