Bug 83066

Summary:

[chromium] Include Image.h in TextFieldDecoratorImpl.cpp

Product:

WebKit

Reporter:

vollick

Component:

WebKit Misc.

Assignee:

vollick

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, jamesr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

vollick

Reported 2012-04-03 14:07:40 PDT

Build fix.

Attachments
Patch (1.16 KB, patch) 2012-04-03 14:25 PDT, vollick	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

vollick

Comment 1 2012-04-03 14:25:59 PDT

Created attachment 135428 [details] Patch

James Robinson

Comment 2 2012-04-03 14:29:31 PDT

What configuration has an error here? Are there any bots that are broken (and if not, why?)

James Robinson

Comment 3 2012-04-03 14:31:24 PDT

And what is the compile error?

James Robinson

Comment 4 2012-04-03 14:33:14 PDT

Ah, do you have SVG disabled locally by any chance? SVGImageCache.h has: #if ENABLE(SVG) #include "Image.h"

James Robinson

Comment 5 2012-04-03 14:42:37 PDT

Comment on attachment 135428 [details] Patch R=me compiling with disable_svg=1 means you're on your own, for the most part.

vollick

Comment 6 2012-04-03 17:31:23 PDT

You're right -- I was compiling with disable_svg=1. I'll be sure to get rid of that gyp define.

WebKit Review Bot

Comment 7 2012-04-03 18:03:57 PDT

Comment on attachment 135428 [details] Patch Clearing flags on attachment: 135428 Committed r113116: <http://trac.webkit.org/changeset/113116>

WebKit Review Bot

Comment 8 2012-04-03 18:04:01 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.