Bug 83065

Summary: kill-old-processes should kill apache2 and httpd
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dpranke, eric, lforschler, ojan, ossy, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric: review+

Ryosuke Niwa
Reported 2012-04-03 14:01:22 PDT
kill-old-processes should kill apache2 and httpd
Attachments
Patch (1.40 KB, patch)
2012-04-03 14:02 PDT, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-04-03 14:02:39 PDT
Created attachment 135421 [details] Patch
Eric Seidel (no email)
Comment 2 2012-04-03 14:07:14 PDT
Comment on attachment 135421 [details] Patch seems OK. Also seems like a hard way to bring down httpd, etc. Also this would suck if you're tryign to run a http server on the same machine as a buildbot. :(
Ryosuke Niwa
Comment 3 2012-04-04 00:27:21 PDT
Committed in http://trac.webkit.org/changeset/113114.
Alexey Proskuryakov
Comment 4 2012-04-04 12:47:33 PDT
Does this mean that a machine with buildbots cannot have web sharing enabled? What is apache2 and why does it need to be killed? This script is quite weird. In addition to "WebKitPluginAgen" without "t", there are mystery processes "Safari Web Content", "TestWebKitAPI Web Content", "WebKitTestRunner Web Content", which I don't think exist anywhere.
Alexey Proskuryakov
Comment 5 2012-04-04 12:48:57 PDT
"per5.12" and "Problem Reporter" are another mystery processes. What's going on here?
Dirk Pranke
Comment 6 2012-04-04 12:52:57 PDT
(In reply to comment #4) > Does this mean that a machine with buildbots cannot have web sharing enabled? > I believe with web sharing, httpd runs as root, so it wouldn't be killed and should be fine. > What is apache2 and why does it need to be killed? apache2 is what most linux distros call httpd (httpd is reserved for apache 1.x), and what new-run-webkit-tests normally uses for the web server. The patch probably only needed httpd on the mac, since it doesn't ship w/ an apache2.
Note You need to log in before you can comment on or make changes to this bug.