[Qt][WK2] Page loading status API lacks a status for intentionally stopped loading

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Marcelo Lira]

Page loading status API lacks a status for intentionally stopped loading

[Marcelo Lira]

Created attachment 135411 [details]
Patch

[Alexis Menard (darktears)]

Comment on attachment 135411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135411&action=review

> Source/WebKit2/ChangeLog:9
> +        is set to the new state LoadStoppedStatus. This reflects reality more accuratelly,

typo : accurately

> Source/WebKit2/ChangeLog:10
> +        for the page was not fully loaded (a LoadSucceededStatus), and it wasn't an unexpected

The english has some issue here.

[Marcelo Lira]

Created attachment 135422 [details]
fixed patch

[Caio Marcelo de Oliveira Filho]

Marcelo: I think would be nice to have API tests for this. :-)

Simon, Tor-Arne: what do you think of this new status?

[Tor Arne Vestbø]

Comment on attachment 135422 [details]
fixed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135422&action=review

lgtm

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:154
> +void QQuickWebViewPrivate::loadDidStopped()

This is a frankenstein of WebKit/Apple and Qt naming convention (did + 'ed) :)

I prefer we keep the Qt one here, loadStopped. Either that or loadDidStop.

[Marcelo Lira]

Created attachment 163168 [details]
Patch

[WebKit Review Bot]

Comment on attachment 163168 [details]
Patch

Clearing flags on attachment: 163168

Committed r128177: <http://trac.webkit.org/changeset/128177>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.