Bug 83020

Summary: [EFL][DRT] FrameloaderClientEfl needs to handle media content correctly
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: WebKit EFLAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, mrobinson, pnormand, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Fixing media content handling in FrameLoaderClientEfl
none
Fixing media content handling in FrameLoaderClientEfl, v2 none

Description Dominik Röttsches (drott) 2012-04-03 05:13:20 PDT 
FrameloaderClientEfl lacks handling for media content types (video/audio), leading to timeouts for example in http/tests/media/media-document.html.
Comment 1 Dominik Röttsches (drott) 2012-04-03 06:58:23 PDT 
Created attachment 135324 [details]
Fixing media content handling in FrameLoaderClientEfl

Fixing media content handling, unskipping related cases.
Comment 2 Ryuan Choi 2012-04-04 01:22:23 PDT 
Comment on attachment 135324 [details]
Fixing media content handling in FrameLoaderClientEfl

View in context: https://bugs.webkit.org/attachment.cgi?id=135324&action=review

Basically Looks good to me.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:789
> +    WebKitErrorPluginWillHandleLoad = 203

Nit, WebKitErrorsPrivate.h define WebKitErrorPlugInWillHandleLoad as 204.
Comment 3 Dominik Röttsches (drott) 2012-04-04 02:52:36 PDT 
Created attachment 135537 [details]
Fixing media content handling in FrameLoaderClientEfl, v2

Addressing enum nit.
Comment 4 WebKit Review Bot 2012-04-04 05:44:02 PDT 
Comment on attachment 135537 [details]
Fixing media content handling in FrameLoaderClientEfl, v2

Clearing flags on attachment: 135537

Committed r113178: <http://trac.webkit.org/changeset/113178>
Comment 5 WebKit Review Bot 2012-04-04 05:44:07 PDT 
All reviewed patches have been landed.  Closing bug.