Bug 83013

Summary:

[chromium] Canvas2DLayerChromium::updateCompositorResources should flush after copying

Product:

WebKit

Reporter:

Sami Kyostila <skyostil>

Component:

Canvas

Assignee:

Sami Kyostila <skyostil>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cc-bugs, jamesr, senorblanco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://www.kevs3d.co.uk/dev/asteroidsbench/

Attachments:

Description	Flags
Patch	none

Description Sami Kyostila 2012-04-03 03:32:17 PDT

Canvas2DLayerChromium::updateCompositorResources should issue a glFlush after copying the canvas back buffer texture to the front buffer. Otherwise the canvas may start rendering new context before the copy is performed, causing the copy to source from partially rendered data.

The flush was there previously but got mistakenly removed when the new TextureCopier utility was added.

Comment 1 Sami Kyostila 2012-04-03 05:13:26 PDT

Created attachment 135313 [details]
Patch

Comment 2 WebKit Review Bot 2012-04-03 07:50:19 PDT

Comment on attachment 135313 [details]
Patch

Clearing flags on attachment: 135313

Committed r113033: <http://trac.webkit.org/changeset/113033>

Comment 3 WebKit Review Bot 2012-04-03 07:50:24 PDT

All reviewed patches have been landed.  Closing bug.