| Summary: | REGRESSION(r80439): Crash in StylePropertySet::borderSpacingValue | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | CSS | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, darin, dbates, hyatt, kling, macpherson, menard, mikelawther, sam, simon.fraser, webkit.review.bot | ||||
| Priority: | P1 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Should specifying -webkit-border-horizontal-spacing also set -webkit-border-vertical-spacing to be consistent with the standard border-spacing property? (border-spacing doesn't allow only vertical spacing to be specified). I'm going to submit a patch assuming that the answer to my question in comment #2 is no (i.e. we want to allow websites specifying border-spacing-vertical without border-spacing-horizontal). Created attachment 135282 [details]
Patch
Comment on attachment 135282 [details]
Patch
Good find.
(In reply to comment #2) > I'm going to submit a patch assuming that the answer to my question in comment #2 is no (i.e. we want to allow websites specifying border-spacing-vertical without border-spacing-horizontal). r=me as is to fix the crash. This question still needs an answer though. I'm going to land this patch as is since we can always revert it if we want the other behavior instead. (In reply to comment #5) > (In reply to comment #2) > > I'm going to submit a patch assuming that the answer to my question in comment #2 is no (i.e. we want to allow websites specifying border-spacing-vertical without border-spacing-horizontal). > > r=me as is to fix the crash. This question still needs an answer though. Yes, please someone answer my question... Comment on attachment 135282 [details] Patch Clearing flags on attachment: 135282 Committed r113049: <http://trac.webkit.org/changeset/113049> All reviewed patches have been landed. Closing bug. |
Reduction: <!DOCTYPE html> <body> <script type="text/javascript"> a = document.createElement("a"); a.setAttribute("style", "-webkit-border-horizontal-spacing:1px;"); a.style.getPropertyValue('border-spacing'); </script> http://crbug.com/121121