Bug 82966

Summary: remove WebKit files from .gitattributes
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, davidbarr, morrita, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2012-04-02 16:17:02 PDT
create Source/WebKit/.gitattributes and move entries from global .gitattributes
Attachments
Patch (3.20 KB, patch)
2012-04-02 16:18 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2012-04-03 16:59 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-04-02 16:18:12 PDT
Created attachment 135220 [details] Patch
Tony Chang
Comment 2 2012-04-03 16:01:07 PDT
I'm skeptical we need any of these since they didn't get updated when WebKit moved to Source. Maybe we should just delete these entries?
David Barr
Comment 3 2012-04-03 16:23:15 PDT
From gitignore(5) which defines the pattern format used in gitattributes(5): http://git-htmldocs.googlecode.com/git/gitignore.html#_pattern_format * Otherwise, git treats the pattern as a shell glob suitable for consumption by fnmatch(3) with the FNM_PATHNAME flag: wildcards in the pattern will not match a / in the pathname. For example, "Documentation/*.html" matches "Documentation/git.html" but not "Documentation/ppc/ppc.html" or "tools/perf/Documentation/perf.html". These rules ceased to apply since the since /WebKit moved into /Source. I'm in favor of deleting these entries unless a compelling reason to update them is found.
Adam Barth
Comment 4 2012-04-03 16:57:59 PDT
> Maybe we should just delete these entries? +1
Tony Chang
Comment 5 2012-04-03 16:59:16 PDT
Created attachment 135458 [details] Patch
WebKit Review Bot
Comment 6 2012-04-03 22:18:20 PDT
Comment on attachment 135458 [details] Patch Clearing flags on attachment: 135458 Committed r113140: <http://trac.webkit.org/changeset/113140>
WebKit Review Bot
Comment 7 2012-04-03 22:18:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.