| Summary: | remove WebKit files from .gitattributes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, davidbarr, morrita, vestbo, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tony Chang
2012-04-02 16:17:02 PDT
Created attachment 135220 [details]
Patch
I'm skeptical we need any of these since they didn't get updated when WebKit moved to Source. Maybe we should just delete these entries? From gitignore(5) which defines the pattern format used in gitattributes(5): http://git-htmldocs.googlecode.com/git/gitignore.html#_pattern_format * Otherwise, git treats the pattern as a shell glob suitable for consumption by fnmatch(3) with the FNM_PATHNAME flag: wildcards in the pattern will not match a / in the pathname. For example, "Documentation/*.html" matches "Documentation/git.html" but not "Documentation/ppc/ppc.html" or "tools/perf/Documentation/perf.html". These rules ceased to apply since the since /WebKit moved into /Source. I'm in favor of deleting these entries unless a compelling reason to update them is found. > Maybe we should just delete these entries?
+1
Created attachment 135458 [details]
Patch
Comment on attachment 135458 [details] Patch Clearing flags on attachment: 135458 Committed r113140: <http://trac.webkit.org/changeset/113140> All reviewed patches have been landed. Closing bug. |