| Summary: | [chromium] Enable sparkline FPS counter in threaded compositing mode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cc-bugs, enne, nduca, shawnsingh, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
James Robinson
2012-04-02 15:48:32 PDT
Created attachment 135210 [details]
Patch
This is a stopgap for debugging stability issues with the threaded scheduler more easily. Comment on attachment 135210 [details]
Patch
Did you consider making initFont and drawFPSCounterText early out rather than making the call conditional? No matter, LrGTM. :)
Yeah, I figured it was weirder to call a function and have it do nothing than to make the caller decide if it wanted to try to init fonts / draw the text. Could go either way. Comment on attachment 135210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135210&action=review R=me. Just not drawing the text sounds like a reasonable short term solution. > Source/WebCore/ChangeLog:12 > + There are no tests for the HUD since it's a developer-facing feature and not user-facing. ಠ_ಠ Comment on attachment 135210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135210&action=review >> Source/WebCore/ChangeLog:12 >> + There are no tests for the HUD since it's a developer-facing feature and not user-facing. > > ಠ_ಠ ¯\(°_o)/¯ Comment on attachment 135210 [details] Patch Clearing flags on attachment: 135210 Committed r113081: <http://trac.webkit.org/changeset/113081> All reviewed patches have been landed. Closing bug. |