| Summary: | Call decrementStatsCounter directly | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||||
| Component: | New Bugs | Assignee: | Mark Pilgrim (Google) <pilgrim> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, fishd, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 82948 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mark Pilgrim (Google)
2012-04-02 14:39:12 PDT
Created attachment 135192 [details]
Patch
Comment on attachment 135192 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135192&action=review > Source/WebKit/chromium/src/PlatformSupport.cpp:-716 > -void PlatformSupport::decrementStatsCounter(const char* name) Can you remove this function from PlatformSupport.h as well? Created attachment 135197 [details]
Patch
(In reply to comment #2) > (From update of attachment 135192 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135192&action=review > > > Source/WebKit/chromium/src/PlatformSupport.cpp:-716 > > -void PlatformSupport::decrementStatsCounter(const char* name) > > Can you remove this function from PlatformSupport.h as well? Done in latest attachment. Comment on attachment 135197 [details]
Patch
Great! It's interesting that there was only one caller and it was in the WebKit layer.
Comment on attachment 135197 [details] Patch Attachment 135197 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12311755 New failing tests: compositing/reflections/backface-hidden-reflection.html Created attachment 135213 [details]
Archive of layout-test-results from ec2-cr-linux-02
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 135197 [details]
Patch
Looks like a flaky test.
Comment on attachment 135197 [details] Patch Clearing flags on attachment: 135197 Committed r112970: <http://trac.webkit.org/changeset/112970> All reviewed patches have been landed. Closing bug. |