Bug 82950

Summary: Call decrementStatsCounter directly
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ec2-cr-linux-02 none

Mark Pilgrim (Google)
Reported 2012-04-02 14:39:12 PDT
Call decrementStatsCounter directly
Attachments
Patch (2.79 KB, patch)
2012-04-02 14:40 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (4.14 KB, patch)
2012-04-02 14:50 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-02 (9.97 MB, application/zip)
2012-04-02 16:01 PDT, WebKit Review Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-04-02 14:40:03 PDT
Created attachment 135192 [details] Patch
Adam Barth
Comment 2 2012-04-02 14:43:31 PDT
Comment on attachment 135192 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135192&action=review > Source/WebKit/chromium/src/PlatformSupport.cpp:-716 > -void PlatformSupport::decrementStatsCounter(const char* name) Can you remove this function from PlatformSupport.h as well?
Mark Pilgrim (Google)
Comment 3 2012-04-02 14:50:32 PDT
Created attachment 135197 [details] Patch
Mark Pilgrim (Google)
Comment 4 2012-04-02 14:51:17 PDT
(In reply to comment #2) > (From update of attachment 135192 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135192&action=review > > > Source/WebKit/chromium/src/PlatformSupport.cpp:-716 > > -void PlatformSupport::decrementStatsCounter(const char* name) > > Can you remove this function from PlatformSupport.h as well? Done in latest attachment.
Adam Barth
Comment 5 2012-04-02 14:53:19 PDT
Comment on attachment 135197 [details] Patch Great! It's interesting that there was only one caller and it was in the WebKit layer.
WebKit Review Bot
Comment 6 2012-04-02 16:01:14 PDT
Comment on attachment 135197 [details] Patch Attachment 135197 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12311755 New failing tests: compositing/reflections/backface-hidden-reflection.html
WebKit Review Bot
Comment 7 2012-04-02 16:01:21 PDT
Created attachment 135213 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Adam Barth
Comment 8 2012-04-02 17:18:06 PDT
Comment on attachment 135197 [details] Patch Looks like a flaky test.
WebKit Review Bot
Comment 9 2012-04-02 18:16:20 PDT
Comment on attachment 135197 [details] Patch Clearing flags on attachment: 135197 Committed r112970: <http://trac.webkit.org/changeset/112970>
WebKit Review Bot
Comment 10 2012-04-02 18:16:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.