Bug 82944

Summary: [mac] LayoutTestHelper crashes if there is no main display
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jberlin, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Tim Horton
Reported 2012-04-02 14:12:22 PDT
It looks like LayoutTestHelper is crashing on some of the bots because ColorSyncDeviceCopyDeviceInfo returns null. It looks like this is probably due to them not having a display. We should check for this case and not do anything to the main display color profile, since I don't see how we can! I'm not sure what will happen to the colorspace of pixel results in that situation, but fixing this can't make it *worse*.
Attachments
patch (2.12 KB, patch)
2012-04-02 14:14 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2012-04-02 14:12:42 PDT
<rdar://problem/11162954>
Tim Horton
Comment 2 2012-04-02 14:14:57 PDT
Created attachment 135183 [details] patch
Tim Horton
Comment 3 2012-04-02 14:24:25 PDT
Landed in http://trac.webkit.org/changeset/112943
Note You need to log in before you can comment on or make changes to this bug.