Bug 82940 – Simplify CSSStyleSelector constructor through the use of a helper function

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Simplify CSSStyleSelector constructor through the use of a helper function

[Eric Seidel (no email)]

Created attachment 135171 [details]
Patch

[Alexis Menard (darktears)]

Comment on attachment 135171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135171&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:410
> +void CSSStyleSelector::addAuthorRulesAndCollectUserRulesFromSheets(const Vector<RefPtr<CSSStyleSheet> >* userSheets, RuleSet& userStyle)

While I see the benefit of the patch to avoid code duplication, I'm not sure whether it's part of the usage to pass a object by reference to modify it.

[Eric Seidel (no email)]

See http://www.webkit.org/coding/coding-style.html "Pointers and References" for minimal guidance on the subject.  In short: yes, we do pass by reference at times.

[Eric Seidel (no email)]

"An out argument of a function should be passed by reference except rare cases where it is optional in which case it should be passed by pointer." seems to suggest that we prefer references to pointers. :)

[Gustavo Noronha (kov)]

Comment on attachment 135171 [details]
Patch

Attachment 135171 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12310679

[Eric Seidel (no email)]

Comment on attachment 135171 [details]
Patch

gtk lies!

[WebKit Review Bot]

Comment on attachment 135171 [details]
Patch

Clearing flags on attachment: 135171

Committed r113016: <http://trac.webkit.org/changeset/113016>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.