Bug 82917

Summary:

[Qt][WK2] ResourceError::isCancellation() is always returning false

Product:

WebKit

Reporter:

Jesus Sanchez-Palencia <jesus>

Component:

WebKit Qt

Assignee:

Jesus Sanchez-Palencia <jesus>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kenneth, menard, webkit.review.bot, zoltan

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jesus Sanchez-Palencia 2012-04-02 11:24:29 PDT

We are missing the encoding of a boolean in ArgumentCoder<ResourceError> and, therefore, we always get the default value (false) for ResourceError::isCancellation() with errors being sent through the IPC.

This is impacting directly the implementation of QtWebPageLoadClient::dispatchLoadFailed, line 95.

Comment 1 Jesus Sanchez-Palencia 2012-04-02 11:45:38 PDT

Created attachment 135142 [details]
Patch

Comment 2 Jesus Sanchez-Palencia 2012-04-02 12:46:55 PDT

Comment on attachment 135142 [details]
Patch

Clearing flags on attachment: 135142

Committed r112921: <http://trac.webkit.org/changeset/112921>

Comment 3 Jesus Sanchez-Palencia 2012-04-02 12:47:02 PDT

All reviewed patches have been landed.  Closing bug.