Bug 82906

Summary: Suppress HTMLMediaElement's text track code when !webkitVideoTrackEnabled()
Product: WebKit Reporter: Ami Fischman <fischman>
Component: MediaAssignee: Ami Fischman <fischman>
Status: RESOLVED FIXED    
Severity: Normal CC: annacc, eric.carlson, vcarbune, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ami Fischman
Reported 2012-04-02 08:56:35 PDT
HTMLMediaElement used to double-guard text track code with both an ENABLE(VIDEO_TRACK) and a RuntimeEnabledFeatures::webkitVideoTrackEnabled() check. But various more-recent CLs (99984, 100064, 102968, 107831, 108241) appear to only use the ENABLE check, effectively turning on a bunch of text track code (visible e.g. with --webcore-log-channels=Media in chromium).
Attachments
Patch (5.19 KB, patch)
2012-04-02 08:57 PDT, Ami Fischman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ami Fischman
Comment 1 2012-04-02 08:57:46 PDT
Created attachment 135111 [details] Patch
WebKit Review Bot
Comment 2 2012-04-02 10:16:19 PDT
Comment on attachment 135111 [details] Patch Clearing flags on attachment: 135111 Committed r112900: <http://trac.webkit.org/changeset/112900>
WebKit Review Bot
Comment 3 2012-04-02 10:16:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.