Bug 82897

Summary: Move GeolocationClient.h to Modules/geolocation/
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, fishd, gustavo, haraken, pnormand, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch haraken: review-, buildbot: commit-queue-

Mark Pilgrim (Google)
Reported 2012-04-02 07:33:08 PDT
Move GeolocationClient.h to Modules/geolocation/
Attachments
Patch (8.66 KB, patch)
2012-04-02 07:34 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (12.35 KB, patch)
2012-04-02 09:09 PDT, Mark Pilgrim (Google) 		haraken: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-04-02 07:34:01 PDT
Created attachment 135098 [details] Patch
Mark Pilgrim (Google)
Comment 2 2012-04-02 07:40:52 PDT
Comment on attachment 135098 [details] Patch This touches some platform-specific build files, so let's wait for all the bots to turn green.
Kentaro Hara
Comment 3 2012-04-02 07:42:40 PDT
Comment on attachment 135098 [details] Patch cq+ is a safe approach. If any build fails, the bot will change it to cq- automatically.
Build Bot
Comment 4 2012-04-02 07:49:29 PDT
Comment on attachment 135098 [details] Patch Attachment 135098 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12314002
Mark Pilgrim (Google)
Comment 5 2012-04-02 09:09:30 PDT
Created attachment 135117 [details] Patch
Mark Pilgrim (Google)
Comment 6 2012-04-02 09:09:57 PDT
Comment on attachment 135117 [details] Patch Fixed Mac build.
Build Bot
Comment 7 2012-04-02 09:21:26 PDT
Comment on attachment 135117 [details] Patch Attachment 135117 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12310552
Philippe Normand
Comment 8 2012-04-02 09:37:45 PDT
Comment on attachment 135117 [details] Patch Attachment 135117 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12310559
Gyuyoung Kim
Comment 9 2012-04-02 10:34:09 PDT
Comment on attachment 135117 [details] Patch Attachment 135117 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12307693
Early Warning System Bot
Comment 10 2012-04-02 10:48:39 PDT
Comment on attachment 135117 [details] Patch Attachment 135117 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12309654
Kentaro Hara
Comment 11 2012-04-19 16:17:23 PDT
Comment on attachment 135117 [details] Patch The change looks OK. Marking r- due to build failures.
Note You need to log in before you can comment on or make changes to this bug.