Bug 82879

Summary: Remove TreeScope::isShadowRoot()
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, hayato, morrita, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Shinya Kawanaka
Reported 2012-04-02 03:42:27 PDT
It seems weird that TreeScope has isShadowRoot(). We should do treeScope->rootNode()->isShadowRoot. Since rootNode() is inlined, the overall performance won't change.
Attachments
Patch (5.06 KB, patch)
2012-04-02 05:52 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-04-02 04:00:45 PDT
Because of this existence, some code requires to include non-necessary ShadowRoot.h...
Shinya Kawanaka
Comment 2 2012-04-02 05:52:29 PDT
Created attachment 135080 [details] Patch
WebKit Review Bot
Comment 3 2012-04-02 20:01:06 PDT
Comment on attachment 135080 [details] Patch Clearing flags on attachment: 135080 Committed r112978: <http://trac.webkit.org/changeset/112978>
WebKit Review Bot
Comment 4 2012-04-02 20:01:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.