Bug 82877

Summary: [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2012-04-02 03:36:01 PDT
The method lstrip is incorrectly used to get the name of failed tests from the full path.
Attachments
Patch (1.18 KB, patch)
2012-04-02 03:39 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-04-02 03:39:50 PDT
Created attachment 135058 [details] Patch
Philippe Normand
Comment 2 2012-04-02 03:45:05 PDT
Comment on attachment 135058 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135058&action=review > Tools/Scripts/run-gtk-tests:268 > + names = [test.replace(self._programs_path, '', 1) for test in failed_tests] What about os.path.basename(test) ?
Carlos Garcia Campos
Comment 3 2012-04-02 03:47:46 PDT
(In reply to comment #2) > (From update of attachment 135058 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135058&action=review > > > Tools/Scripts/run-gtk-tests:268 > > + names = [test.replace(self._programs_path, '', 1) for test in failed_tests] > > What about os.path.basename(test) ? that would give you the name, but we also want the directory unittests/WebKit2APITests
Philippe Normand
Comment 4 2012-04-02 03:52:35 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 135058 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=135058&action=review > > > > > Tools/Scripts/run-gtk-tests:268 > > > + names = [test.replace(self._programs_path, '', 1) for test in failed_tests] > > > > What about os.path.basename(test) ? > > that would give you the name, but we also want the directory unittests/WebKit2APITests Is it really useful? The test naming conventions differ between WK1 and WK2
Carlos Garcia Campos
Comment 5 2012-04-02 03:54:52 PDT
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 135058 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=135058&action=review > > > > > > > Tools/Scripts/run-gtk-tests:268 > > > > + names = [test.replace(self._programs_path, '', 1) for test in failed_tests] > > > > > > What about os.path.basename(test) ? > > > > that would give you the name, but we also want the directory unittests/WebKit2APITests > > Is it really useful? > The test naming conventions differ between WK1 and WK2 That's how we refer to tests, see SkippedTest class
Carlos Garcia Campos
Comment 6 2012-04-02 04:07:19 PDT
Committed r112853: <http://trac.webkit.org/changeset/112853>
Note You need to log in before you can comment on or make changes to this bug.