Bug 82797

Summary: Support currentTransform and other SVGMatrix interactions
Product: WebKit Reporter: Dean Jackson <dino>
Component: CanvasAssignee: Dean Jackson <dino>
Status: NEW ---    
Severity: Normal CC: abarth, chkang514, dglazkov, dongseong.hwang, eoconnor, eric, guanqun.lu, haraken, japhet, jochen, junov, kling, pdr, rwlbuis, simon.fraser, webkit-bug-importer, webkit.review.bot, zimmermann
Priority: P2 Keywords: InRadar, WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84006    
Bug Blocks:    
Attachments:
Description Flags
patch v.1
webkit.review.bot: commit-queue-
Test : various currentTransform tests
dongseong.hwang: commit-queue-
Archive of layout-test-results from ec2-cr-linux-04
none
patch v.2
none
Test : various currentTransform tests
webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-01
none
patch krit: review-, krit: commit-queue-

Description Dean Jackson 2012-03-30 15:55:57 PDT
canvas v5 has a currentTransform that is an SVGMatrix, as well as the ability to reset it, and perform some matrix functions.

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-currenttransform
Comment 1 Radar WebKit Bug Importer 2012-03-30 15:56:22 PDT
<rdar://problem/11159319>
Comment 2 Dongseong Hwang 2012-06-29 05:28:40 PDT
Created attachment 150150 [details]
patch v.1
Comment 3 Dongseong Hwang 2012-06-29 05:29:29 PDT
Created attachment 150152 [details]
Test : various currentTransform tests
Comment 4 WebKit Review Bot 2012-06-29 06:03:58 PDT
Comment on attachment 150150 [details]
patch v.1

Attachment 150150 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13118269
Comment 5 WebKit Review Bot 2012-06-29 06:44:31 PDT
Comment on attachment 150152 [details]
Test : various currentTransform tests

Attachment 150152 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13113346

New failing tests:
platform/chromium/virtual/gpu/fast/canvas/canvas-currentTransform.html
fast/canvas/canvas-currentTransform.html
Comment 6 WebKit Review Bot 2012-06-29 06:44:34 PDT
Created attachment 150166 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 Dongseong Hwang 2012-06-29 08:05:17 PDT
Created attachment 150179 [details]
patch v.2
Comment 8 Dongseong Hwang 2012-06-29 08:37:07 PDT
Created attachment 150190 [details]
Test : various currentTransform tests

Patch again in order to pass chromium.
Comment 9 WebKit Review Bot 2012-06-29 11:06:08 PDT
Comment on attachment 150190 [details]
Test : various currentTransform tests

Attachment 150190 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13119402

New failing tests:
platform/chromium/virtual/gpu/fast/canvas/canvas-currentTransform.html
fast/canvas/canvas-currentTransform.html
Comment 10 WebKit Review Bot 2012-06-29 11:06:13 PDT
Created attachment 150219 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 11 Dongseong Hwang 2012-06-29 18:37:36 PDT
(In reply to comment #10)
> Created an attachment (id=150219) [details]
> Archive of layout-test-results from ec2-cr-linux-01
> 
> The attached test failures were seen while running run-webkit-tests on the chromium-ews.
> Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

I think new layout test can pass to chromium port after applying "patch v.2".
Comment 12 Dongseong Hwang 2012-07-01 16:39:03 PDT
Created attachment 150342 [details]
patch

Get patch and test together in order to pass chromium ews.
Comment 13 Dongseong Hwang 2012-07-13 19:14:17 PDT
I'll very appreciate if Dean or Simon take a look at this bug.
Comment 14 Eric Seidel (no email) 2012-08-22 15:46:36 PDT
We seem to be missing all the SVG folks from this bug...
Comment 15 Dirk Schulze 2013-02-15 23:34:13 PST
Comment on attachment 150342 [details]
patch

This patch does most probably not apply anymore and is not the right way to go. We should use a more SVG unrelated approach like with the Matrix proposal in bug 110001.