Bug 82797

Summary:

Support currentTransform and other SVGMatrix interactions

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

Canvas

Assignee:

Dean Jackson <dino>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

abarth, annevk, chkang514, dglazkov, dongseong.hwang, eoconnor, eric, guanqun.lu, haraken, japhet, jochen, junov, kling, pdr, rwlbuis, simon.fraser, webkit-bug-importer, webkit.review.bot, zimmermann

Priority:

Keywords:

InRadar, WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

84006

Bug Blocks:

Attachments:

Description	Flags
patch v.1	webkit.review.bot: commit-queue-
Test : various currentTransform tests	dongseong.hwang: commit-queue-
Archive of layout-test-results from ec2-cr-linux-04	none
patch v.2	none
Test : various currentTransform tests	webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-01	none
patch	krit: review-, krit: commit-queue-

Dean Jackson

Reported 2012-03-30 15:55:57 PDT

canvas v5 has a currentTransform that is an SVGMatrix, as well as the ability to reset it, and perform some matrix functions. http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-currenttransform

Attachments
patch v.1 (8.27 KB, patch) 2012-06-29 05:28 PDT, Dongseong Hwang	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Test : various currentTransform tests (5.92 KB, patch) 2012-06-29 05:29 PDT, Dongseong Hwang	dongseong.hwang: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-04 (495.55 KB, application/zip) 2012-06-29 06:44 PDT, WebKit Review Bot	no flags	Details
patch v.2 (8.24 KB, patch) 2012-06-29 08:05 PDT, Dongseong Hwang	no flags	Details Formatted Diff Diff
Test : various currentTransform tests (5.92 KB, patch) 2012-06-29 08:37 PDT, Dongseong Hwang	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-01 (731.74 KB, application/zip) 2012-06-29 11:06 PDT, WebKit Review Bot	no flags	Details
patch (13.90 KB, patch) 2012-07-01 16:39 PDT, Dongseong Hwang	krit: review- krit: commit-queue-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2012-03-30 15:56:22 PDT

<rdar://problem/11159319>

Dongseong Hwang

Comment 2 2012-06-29 05:28:40 PDT

Created attachment 150150 [details] patch v.1

Dongseong Hwang

Comment 3 2012-06-29 05:29:29 PDT

Created attachment 150152 [details] Test : various currentTransform tests

WebKit Review Bot

Comment 4 2012-06-29 06:03:58 PDT

Comment on attachment 150150 [details] patch v.1 Attachment 150150 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13118269

WebKit Review Bot

Comment 5 2012-06-29 06:44:31 PDT

Comment on attachment 150152 [details] Test : various currentTransform tests Attachment 150152 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13113346 New failing tests: platform/chromium/virtual/gpu/fast/canvas/canvas-currentTransform.html fast/canvas/canvas-currentTransform.html

WebKit Review Bot

Comment 6 2012-06-29 06:44:34 PDT

Created attachment 150166 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Dongseong Hwang

Comment 7 2012-06-29 08:05:17 PDT

Created attachment 150179 [details] patch v.2

Dongseong Hwang

Comment 8 2012-06-29 08:37:07 PDT

Created attachment 150190 [details] Test : various currentTransform tests Patch again in order to pass chromium.

WebKit Review Bot

Comment 9 2012-06-29 11:06:08 PDT

Comment on attachment 150190 [details] Test : various currentTransform tests Attachment 150190 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13119402 New failing tests: platform/chromium/virtual/gpu/fast/canvas/canvas-currentTransform.html fast/canvas/canvas-currentTransform.html

WebKit Review Bot

Comment 10 2012-06-29 11:06:13 PDT

Created attachment 150219 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Dongseong Hwang

Comment 11 2012-06-29 18:37:36 PDT

(In reply to comment #10) > Created an attachment (id=150219) [details] > Archive of layout-test-results from ec2-cr-linux-01 > > The attached test failures were seen while running run-webkit-tests on the chromium-ews. > Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick I think new layout test can pass to chromium port after applying "patch v.2".

Dongseong Hwang

Comment 12 2012-07-01 16:39:03 PDT

Created attachment 150342 [details] patch Get patch and test together in order to pass chromium ews.

Dongseong Hwang

Comment 13 2012-07-13 19:14:17 PDT

I'll very appreciate if Dean or Simon take a look at this bug.

Eric Seidel (no email)

Comment 14 2012-08-22 15:46:36 PDT

We seem to be missing all the SVG folks from this bug...

Dirk Schulze

Comment 15 2013-02-15 23:34:13 PST

Comment on attachment 150342 [details] patch This patch does most probably not apply anymore and is not the right way to go. We should use a more SVG unrelated approach like with the Matrix proposal in bug 110001.

Anne van Kesteren

Comment 16 2024-09-04 01:21:58 PDT

It seems this got redesigned at some point in the specification.

Note You need to log in before you can comment on or make changes to this bug.