Bug 82786

Summary: Add a compile assert for the size of FontDescription
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, gustavo, kling, koivisto, mitz, ojan, pnormand, tony, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric: review+, pnormand: commit-queue-

Ryosuke Niwa
Reported 2012-03-30 14:58:54 PDT
Add a compile assert for the size of FontDescription
Attachments
Patch (3.16 KB, patch)
2012-03-30 15:07 PDT, Ryosuke Niwa 		eric: review+
pnormand: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-03-30 15:07:52 PDT
Created attachment 134895 [details] Patch
Philippe Normand
Comment 2 2012-03-30 15:24:02 PDT
Comment on attachment 134895 [details] Patch Attachment 134895 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12266544
Eric Seidel (no email)
Comment 3 2012-03-30 15:24:44 PDT
Comment on attachment 134895 [details] Patch Seems reasonable.
Ryosuke Niwa
Comment 4 2012-03-30 15:30:50 PDT
Comment on attachment 134895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134895&action=review > Source/WebCore/platform/graphics/FontDescription.cpp:42 > + uint32_t bitfields : 8; Oops, gotta rename this :(
Ryosuke Niwa
Comment 5 2012-03-30 15:36:13 PDT
Committed r112736: <http://trac.webkit.org/changeset/112736>
Note You need to log in before you can comment on or make changes to this bug.