Bug 82780

Summary: Add a compile assert for the size of RenderText
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, eric, gustavo, kling, koivisto, ojan, pnormand, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fixed gtk build
webkit-ews: commit-queue-
Another build fix dpranke: review+

Ryosuke Niwa
Reported 2012-03-30 14:24:59 PDT
Add a compile assert for the size of RenderText
Attachments
Patch (1.30 KB, patch)
2012-03-30 14:25 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed gtk build (2.19 KB, patch)
2012-03-30 15:01 PDT, Ryosuke Niwa 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Another build fix (2.66 KB, patch)
2012-03-30 15:40 PDT, Ryosuke Niwa 		dpranke: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-03-30 14:25:48 PDT
Created attachment 134882 [details] Patch
Philippe Normand
Comment 2 2012-03-30 14:31:05 PDT
Comment on attachment 134882 [details] Patch Attachment 134882 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12288439
Ryosuke Niwa
Comment 3 2012-03-30 14:35:26 PDT
As I suspected, we need to re-order floats here.
Ryosuke Niwa
Comment 4 2012-03-30 15:01:50 PDT
Created attachment 134890 [details] Fixed gtk build
Early Warning System Bot
Comment 5 2012-03-30 15:24:58 PDT
Comment on attachment 134890 [details] Fixed gtk build Attachment 134890 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12253485
Early Warning System Bot
Comment 6 2012-03-30 15:27:48 PDT
Comment on attachment 134890 [details] Fixed gtk build Attachment 134890 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12262469
WebKit Review Bot
Comment 7 2012-03-30 15:29:00 PDT
Comment on attachment 134890 [details] Fixed gtk build Attachment 134890 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12265492
Build Bot
Comment 8 2012-03-30 15:31:50 PDT
Comment on attachment 134890 [details] Fixed gtk build Attachment 134890 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12265490
Ryosuke Niwa
Comment 9 2012-03-30 15:39:51 PDT
Oops, I also need to change the order of initialization :(
Ryosuke Niwa
Comment 10 2012-03-30 15:40:04 PDT
Created attachment 134902 [details] Another build fix
Dirk Pranke
Comment 11 2012-03-30 21:50:26 PDT
Comment on attachment 134902 [details] Another build fix View in context: https://bugs.webkit.org/attachment.cgi?id=134902&action=review > Source/WebCore/ChangeLog:8 > + Added an assertion. You should probably note that you moved fields around as well ...
Ryosuke Niwa
Comment 12 2012-03-30 22:16:40 PDT
Committed r112776: <http://trac.webkit.org/changeset/112776>
Note You need to log in before you can comment on or make changes to this bug.