Summary: | [Chromium] defaultDeviceScaleFactor != 0 should set deviceScaleFactor = defaultDeviceScaleFactor in the absence of a viewport tag for debugging purposes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fady Samuel <fsamuel> | ||||||
Component: | Layout and Rendering | Assignee: | Tim Dresser <tdresser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, aelias, fishd, fsamuel, mbolohan, rjkroege, tdresser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 70559 | ||||||||
Attachments: |
|
Description
Fady Samuel
2012-03-30 11:12:38 PDT
Created attachment 135356 [details]
Patch
This looks good to me. Thanks. Added abarth@ for review. Looks like this should be a no-op patch if the setting isn't changed, so it's fine by me. I'd be curious to know what kind of debugging you have in mind though. (In reply to comment #4) > Looks like this should be a no-op patch if the setting isn't changed, so it's fine by me. I'd be curious to know what kind of debugging you have in mind though. Manually passing --default-device-scale-factor=2 in Chromium and browsing. Comment on attachment 135356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135356&action=review > Source/WebKit/chromium/tests/WebFrameTest.cpp:34 > +#include "FrameView.h" please avoid reaching into WebCore if you can help it. > Source/WebKit/chromium/tests/WebFrameTest.cpp:181 > + webViewImpl->resize(WebSize(viewportWidth, viewportHeight)); Why do you need to use WebViewImpl here? > Source/WebKit/chromium/tests/WebFrameTest.cpp:185 > + webViewImpl->mainFrameImpl()->frameView()->layout(); just call WebWidget::layout()? WebView inherits from WebWidget Created attachment 136452 [details]
Patch
(In reply to comment #6) > (From update of attachment 135356 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135356&action=review > > > Source/WebKit/chromium/tests/WebFrameTest.cpp:34 > > +#include "FrameView.h" > > please avoid reaching into WebCore if you can help it. > > > Source/WebKit/chromium/tests/WebFrameTest.cpp:181 > > + webViewImpl->resize(WebSize(viewportWidth, viewportHeight)); > > Why do you need to use WebViewImpl here? > > > Source/WebKit/chromium/tests/WebFrameTest.cpp:185 > > + webViewImpl->mainFrameImpl()->frameView()->layout(); > > just call WebWidget::layout()? WebView inherits from WebWidget Done. Comment on attachment 136452 [details] Patch Clearing flags on attachment: 136452 Committed r113782: <http://trac.webkit.org/changeset/113782> All reviewed patches have been landed. Closing bug. |