Bug 82756

Summary: Add a compile assert for the size of CSSProperty
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, eric, gustavo, kling, koivisto, macpherson, menard, ojan, pnormand, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+, pnormand: commit-queue-

Ryosuke Niwa
Reported 2012-03-30 11:10:19 PDT
Add a compile assert for the size of CSSProperty
Attachments
Patch (4.54 KB, patch)
2012-03-30 11:11 PDT, Ryosuke Niwa 		kling: review+
pnormand: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-03-30 11:11:32 PDT
Created attachment 134841 [details] Patch
Andreas Kling
Comment 2 2012-03-30 11:15:52 PDT
Comment on attachment 134841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134841&action=review r=me > Source/WebCore/css/CSSProperty.h:60 > +private: Whoa. Great change.
Ojan Vafai
Comment 3 2012-03-30 11:17:44 PDT
Comment on attachment 134841 [details] Patch This patch does a lot more than just add a compile assert! Please add descriptions for the other changes (wrapValue && bool-->unsigned && making member variables private).
Philippe Normand
Comment 4 2012-03-30 11:21:45 PDT
Comment on attachment 134841 [details] Patch Attachment 134841 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12266417
Ryosuke Niwa
Comment 5 2012-03-30 11:27:22 PDT
Committed r112699: <http://trac.webkit.org/changeset/112699>
Note You need to log in before you can comment on or make changes to this bug.