Bug 82753

Summary: Web Inspector: CodeGeneratorInspector.py: add missing runtime assert method for InspectorObject
Product: WebKit Reporter: Peter Rybin <prybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Peter Rybin
Reported 2012-03-30 10:52:55 PDT
Do not allow InspectorObject and other raw interfaces from Console and DOMDebugger domains anymore.
Attachments
Patch (6.77 KB, patch)
2012-03-30 11:02 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (6.77 KB, patch)
2012-03-30 11:33 PDT, Peter Rybin 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2012-03-30 11:02:14 PDT
Created attachment 134840 [details] Patch
Vsevolod Vlasov
Comment 2 2012-03-30 11:19:40 PDT
Comment on attachment 134840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134840&action=review > Source/WebCore/ChangeLog:10 > + Type validator generator is extended to support missing InspectorObject type and Looks like this is main thing done in this patch. Could you please name the bug accordignly?
Peter Rybin
Comment 3 2012-03-30 11:28:18 PDT
Among all types that needs assert for runtime validator, InspectorObject is missing and should be also supported. Switching Console and DOMDebugger to strict typed api reduces to more of a drive-by fix.
Peter Rybin
Comment 4 2012-03-30 11:33:11 PDT
Created attachment 134846 [details] Patch
Vsevolod Vlasov
Comment 5 2012-03-30 11:54:23 PDT
Committed r112706: <http://trac.webkit.org/changeset/112706>
Note You need to log in before you can comment on or make changes to this bug.