Bug 82751

Summary:

http/tests/security/cross-frame-access-put.html is failing

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, cdumez, haraken, sam, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	haraken: review+, ap: commit-queue-
Patch	none

Simon Fraser (smfr)

Reported 2012-03-30 10:50:59 PDT

http://build.webkit.org/results/Lion%20Debug%20(Tests)/r112674%20(5107)/results.html

Attachments
Patch (1.80 KB, patch) 2012-04-26 00:24 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (132.31 KB, patch) 2012-04-26 00:44 PDT, Chris Dumez	haraken: review+ ap: commit-queue-	Details Formatted Diff Diff
Patch (132.40 KB, patch) 2012-04-26 01:56 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2012-04-01 00:56:08 PDT

This link is 404.

Radar WebKit Bug Importer

Comment 2 2012-04-01 00:56:45 PDT

<rdar://problem/11162572>

Alexey Proskuryakov

Comment 3 2012-04-02 10:10:39 PDT

-ALERT: PASS: window.frameElement should be 'undefined' and is. +ALERT: PASS: window.frameElement should be 'null' and is. Looks like results just need to be updated per bug 80205. That bug updated chromium and Gtk, but for some reason not cross-platform or Qt.

Chris Dumez

Comment 4 2012-04-26 00:06:31 PDT

Yes, we have a similar issue in the EFL port. bug 80205 has not updated the following global expectation: LayoutTests/http/tests/security/cross-frame-access-put-expected.txt

Chris Dumez

Comment 5 2012-04-26 00:24:33 PDT

Created attachment 138948 [details] Patch Proposing patch to update global expected result for http/tests/security/cross-frame-access-put.html test. The value of window.frameElement is now 'null' instead of 'undefined' when shouldAllowAccessToNode() check fails, after bug 80205 fix. - This fixes the test for EFL port which does not have platform-specific expectation. - GTK, Qt, Chromium ports have platform-specific expectations and have already been updated. - The test is skipped on wincairo, qt-mac, qt-arm, wk2, win and mac.

Chris Dumez

Comment 6 2012-04-26 00:44:58 PDT

Created attachment 138949 [details] Patch Update patch to remove Qt/GTK-specific expectations now they are identical to the global one.

Kentaro Hara

Comment 7 2012-04-26 01:39:52 PDT

Comment on attachment 138949 [details] Patch Thank you very much for the rebaselining!

Alexey Proskuryakov

Comment 8 2012-04-26 01:41:09 PDT

Comment on attachment 138949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138949&action=review > LayoutTests/ChangeLog:14 > + * http/tests/security/cross-frame-access-put-expected.txt: The ChangeLog needs to be regenerated to list deleted files. You can also move comments from above to make them per-file.

Chris Dumez

Comment 9 2012-04-26 01:56:03 PDT

Created attachment 138955 [details] Patch Update Changelog as per AP's recommendation.

WebKit Review Bot

Comment 10 2012-04-26 03:26:59 PDT

Comment on attachment 138955 [details] Patch Clearing flags on attachment: 138955 Committed r115299: <http://trac.webkit.org/changeset/115299>

WebKit Review Bot

Comment 11 2012-04-26 03:27:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.