Summary: | http/tests/security/cross-frame-access-put.html is failing | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, ap, cdumez, haraken, sam, webkit-bug-importer, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2012-03-30 10:50:59 PDT
This link is 404. -ALERT: PASS: window.frameElement should be 'undefined' and is. +ALERT: PASS: window.frameElement should be 'null' and is. Looks like results just need to be updated per bug 80205. That bug updated chromium and Gtk, but for some reason not cross-platform or Qt. Yes, we have a similar issue in the EFL port. bug 80205 has not updated the following global expectation: LayoutTests/http/tests/security/cross-frame-access-put-expected.txt Created attachment 138948 [details] Patch Proposing patch to update global expected result for http/tests/security/cross-frame-access-put.html test. The value of window.frameElement is now 'null' instead of 'undefined' when shouldAllowAccessToNode() check fails, after bug 80205 fix. - This fixes the test for EFL port which does not have platform-specific expectation. - GTK, Qt, Chromium ports have platform-specific expectations and have already been updated. - The test is skipped on wincairo, qt-mac, qt-arm, wk2, win and mac. Created attachment 138949 [details]
Patch
Update patch to remove Qt/GTK-specific expectations now they are identical to the global one.
Comment on attachment 138949 [details]
Patch
Thank you very much for the rebaselining!
Comment on attachment 138949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138949&action=review > LayoutTests/ChangeLog:14 > + * http/tests/security/cross-frame-access-put-expected.txt: The ChangeLog needs to be regenerated to list deleted files. You can also move comments from above to make them per-file. Created attachment 138955 [details]
Patch
Update Changelog as per AP's recommendation.
Comment on attachment 138955 [details] Patch Clearing flags on attachment: 138955 Committed r115299: <http://trac.webkit.org/changeset/115299> All reviewed patches have been landed. Closing bug. |