Bug 82742

Summary:

Two lineboxcontain tests are failing

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Julien Chaffraix <jchaffraix>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hyatt, jchaffraix, mitz, ojan, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed simple rebaselining (should be trivial but I don't know if this could impact wk2).	none

Simon Fraser (smfr)

Reported 2012-03-30 10:29:05 PDT

These two tests are failing. I'm skipping them for now. fast/block/lineboxcontain/block-glyphs-replaced.html fast/block/lineboxcontain/glyphs.html

Attachments
Proposed simple rebaselining (should be trivial but I don't know if this could impact wk2). (7.89 KB, patch) 2012-04-13 13:54 PDT, Julien Chaffraix	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2012-03-30 10:29:39 PDT

See also bug 82129.

Ojan Vafai

Comment 2 2012-03-30 10:41:55 PDT

Looking at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fblock%2Flineboxcontain%2Fblock-glyphs-replaced.html%20fast%2Fblock%2Flineboxcontain%2Fglyphs.html here's the regression range: http://trac.webkit.org/log/?verbose=on&rev=112582&stop_rev=112581. Clearly http://trac.webkit.org/changeset/112582/ is the culprit.

Simon Fraser (smfr)

Comment 3 2012-03-30 10:58:13 PDT

I skipped them.

Julien Chaffraix

Comment 4 2012-03-30 11:18:46 PDT

It looks like I forgot to update / skip them when landing bug 82129. They should only be layers' additions, no position / size change. I will look into them next week, sorry for the noise.

Julien Chaffraix

Comment 5 2012-04-13 13:54:42 PDT

Created attachment 137142 [details] Proposed simple rebaselining (should be trivial but I don't know if this could impact wk2).

WebKit Review Bot

Comment 6 2012-04-13 19:33:27 PDT

Comment on attachment 137142 [details] Proposed simple rebaselining (should be trivial but I don't know if this could impact wk2). Clearing flags on attachment: 137142 Committed r114198: <http://trac.webkit.org/changeset/114198>

WebKit Review Bot

Comment 7 2012-04-13 19:33:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.