Summary: | [chromium] Flaky animation unit test CCLayerTreeHostTestSynchronizeAnimationStartTimes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | vollick | ||||
Component: | WebKit Misc. | Assignee: | vollick | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | danakj, jamesr, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
vollick
2012-03-30 07:24:32 PDT
Created attachment 134809 [details]
Patch
Comment on attachment 134809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134809&action=review R=me, but you don't need this extra pointer. > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:1069 > + , m_layerTreeHostImpl(0) you don't need this, there's already a public layerTreeHost() getter on your grand-father class (CCLayerTreeHostTest). (In reply to comment #2) > (From update of attachment 134809 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134809&action=review > > R=me, but you don't need this extra pointer. > > > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:1069 > > + , m_layerTreeHostImpl(0) > > you don't need this, there's already a public layerTreeHost() getter on your grand-father class (CCLayerTreeHostTest). I wasn't sure if there was a way to get the CCLayerTreeHostImpl associated with the CCLayerTreeHost obtained from layerTreeHost(). My best thought was to grab a pointer to it from one of the test hooks. Is there a better way? Oh sorry, I misread (haven't woken up yet I suppose). Your approach seems good. Comment on attachment 134809 [details] Patch Clearing flags on attachment: 134809 Committed r112708: <http://trac.webkit.org/changeset/112708> All reviewed patches have been landed. Closing bug. |